lucasw89/STCourses
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(studio): review round 1 for imported-course editing

Browse Source 
- Media exclusions move from the editable root .gitignore to the repo's
  info/exclude, and dirtyFiles never counts files listed in media.json, so an
  author's or remote's .gitignore cannot block publish or Sync. Publish and
  Sync refuse commits that track a file over referenced media.
- Importer jobs (code-repo, pdf-deck, transcribe) and the cover route run
  under the course lock now shared with the studio (core withCourseLock) and
  re-check the course inside it; after conversion they fail with "this course
  is now edited in the studio". Convert answers 409 while an import job for
  the course is queued or running, and the job re-checks.
- Crash-safe conversion: the import folder is hidden (.converting-<id>) before
  the published worktree exists; cross-filesystem moves copy into a staging
  dir, fsync, verify size and sha256, then rename; the source is retired as
  .converted-<id>.<n>. Recovery runs at server start and before every convert;
  a re-run of a finished conversion reports success. The loader skips
  dot-folders.
- Minor: no raw NUL bytes in source, link fallback only on EXDEV/EPERM/EMLINK,
  referenced media are not read whole by the editor, missing media are logged,
  mediaDir JSDoc, docs on per-author copies across filesystems.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Lucas Winther
2026-10-30 20:53:50 +01:00
co-authored by Claude Opus 5.5
parent 08e62ff683
commit 771d755da4
17 changed files with 618 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/feature-studio/src/server/media-refs.ts
+5 -5
View File
@@ -3,8 +3,8 @@ import { checkRelPath } from "./relpath";
/**
* Large media of a converted import stay out of git (v1.1 S, docs/operations.md "Imported courses in the studio").
* The repo commits `MEDIA_REFS` (path, size and checksum per file, spec 5) and a `.gitignore` line per path;
* every studio worktree gets the files as hard links to `<dataDir>/media/<courseId>/<path>`.
* The repo commits `MEDIA_REFS` (path, size and checksum per file, spec 5); the repo's `info/exclude` (not the
* author-editable `.gitignore`) gets one line per path, and the studio never counts them as changes. Every studio worktree gets the files as hard links to `<dataDir>/media/<courseId>/<path>`.
*/
export const MEDIA_REFS = ".stcourses/media.json";
export const LARGE_FILE_BYTES = 8 * 1024 * 1024;
@@ -26,12 +26,12 @@ export function gitignoreLine(rel: string): string {
return `/${s}`;
}
const HEADER = "# Imported media kept outside git: see .stcourses/media.json (STCourses)";
export const MEDIA_EXCLUDE_HEADER = "# Imported media kept outside git: see .stcourses/media.json (STCourses)";
/** The repo's root `.gitignore`: the course's own one (if any) first, then one line per referenced file. */
/** Ignore-file content: `existing` (if any) first, then the header and one line per referenced file. */
export function mediaGitignore(paths: string[], existing: string | null): string {
const own = existing ? (existing.endsWith("\n") ? existing : existing + "\n") + "\n" : "";
return `${own}${HEADER}\n${paths.map(gitignoreLine).join("\n")}\n`;
return `${own}${MEDIA_EXCLUDE_HEADER}\n${paths.map(gitignoreLine).join("\n")}\n`;
}
export async function sha256File(abs: string): Promise<string> {