fix: final-review wave (CSRF guard, fail-closed owner bootstrap, streamed zips, e2e visibility suite)

- Critical 1 (CSRF): core wrap refuses every POST/PUT/PATCH/DELETE whose Origin
  (Referer as fallback) is not publicUrl's origin or STC_ALLOWED_ORIGINS, and
  any body that is not application/json (multipart only on declared upload
  routes). Better Auth routes go through the same guard; only declared
  identity-provider callbacks (SAML ACS/SLO, OAuth callbacks) are exempt.
  Better Auth trustedOrigins use the same list. Session cookie stays Lax
  (Strict breaks OAuth/OIDC/SAML returns); documented.
- Important 4 / learner minor 4: the first-owner claim and the role row are
  one transaction guarded by "no owner yet"; only a unique violation means
  learner; any other error fails the sign-up with 500 and removes the
  half-created user. Serialised per DB handle (Bun's SQLite connection).
- Important 2 / learner minor 12: code zips stream entry by entry (large
  files stored in 256 KB chunks with a data descriptor and incremental
  CRC-32), so memory stays at one chunk; the cap is now 1 GiB (ZIP32).
- Important 3 / learner minor 10: the e2e runs the production wiring
  (productFeatures order, AI drafts through the real sink) against a
  restricted course and asserts 404/401 for learner and anonymous on
  course, lesson, media, cover, code, zip, notes, progress, attempts, AI
  chat, library, search and AI status; a real Range request (206, 416);
  forged writes (foreign Origin, text/plain, no Origin) are 403 and the MCP
  test command never runs.
- Minors 7-9: compose passes every documented variable; the health check
  uses STC_PORT; productFeatures checks the studio-before-AI order.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Lucas Winther
2026-10-30 15:42:17 +01:00
co-authored by Claude Opus 5.5
parent 69aaedcb43
commit 8045c80d93
24 changed files with 725 additions and 85 deletions
+42 -2
View File
@@ -1,5 +1,5 @@
import { expect, test } from "bun:test";
import { assignInitialRole } from "../src/server/auth";
import { expect, spyOn, test } from "bun:test";
import { assignInitialRole, isUniqueViolation } from "../src/server/auth";
import { syncClaimGroups, groupsFromClaims } from "../src/server/auth/groups";
import { forEachDb } from "./helpers";
import { cookieFrom, makeApp } from "./app";
@@ -60,3 +60,43 @@ test("groupsFromClaims reads arrays and strings", () => {
expect(groupsFromClaims({ extraFields: { groups: ["z"] } })).toEqual(["z"]);
expect(groupsFromClaims(null)).toEqual([]);
});
forEachDb("owner bootstrap fails closed: an injected failure refuses the sign-up, no silent learner, no free owner slot", async (db) => {
const t = await makeApp(db);
const count = async (q: string) => Number((await db.sql.unsafe(q))[0].n);
const err = spyOn(console, "error").mockImplementation(() => {});
try {
// The role table is unreachable: role assignment fails with a non-unique error.
await db.sql.unsafe("ALTER TABLE user_roles RENAME TO user_roles_off");
const signUp = (email: string) => t.call("POST", "/api/auth/sign-up/email", { body: { email, name: "X", password: "correct horse battery" } });
const first = await signUp("first@example.com");
expect(first.status).toBe(500);
// nothing is left: no account, no owner claim
expect(await count("SELECT COUNT(*) AS n FROM auth_user")).toBe(0);
expect(await count("SELECT COUNT(*) AS n FROM learner_meta WHERE key = 'owner'")).toBe(0);
// while the failure lasts, the next sign-up does not become owner either: it fails the same way
expect((await signUp("stranger@example.com")).status).toBe(500);
expect(await count("SELECT COUNT(*) AS n FROM auth_user")).toBe(0);
expect(await count("SELECT COUNT(*) AS n FROM learner_meta WHERE key = 'owner'")).toBe(0);
// once the database recovers, the first completed account is the owner, the next a learner
await db.sql.unsafe("ALTER TABLE user_roles_off RENAME TO user_roles");
const own = await t.signUp("first@example.com");
const lea = await t.signUp("stranger@example.com");
expect((await (await t.call("GET", "/api/me", { cookie: own })).json()).user.roles).toEqual(["owner"]);
expect((await (await t.call("GET", "/api/me", { cookie: lea })).json()).user.roles).toEqual(["learner"]);
} finally {
err.mockRestore();
}
}, 30_000);
forEachDb("assignInitialRole rethrows anything but a unique violation, and rolls the owner claim back", async (db) => {
await db.sql.unsafe("ALTER TABLE user_roles RENAME TO user_roles_off");
await expect(assignInitialRole(db, "u1")).rejects.toThrow();
expect((await db.sql`SELECT COUNT(*) AS n FROM learner_meta WHERE key = 'owner'`)[0].n.toString()).toBe("0");
await db.sql.unsafe("ALTER TABLE user_roles_off RENAME TO user_roles");
expect(await assignInitialRole(db, "u1")).toBe("owner");
expect(await assignInitialRole(db, "u2")).toBe("learner");
expect(isUniqueViolation({ code: "23505" })).toBe(true);
expect(isUniqueViolation(new Error("UNIQUE constraint failed: learner_meta.key"))).toBe(true);
expect(isUniqueViolation(new Error("no such table: user_roles"))).toBe(false);
});