fix(purchase): one control language in the purchase dialog

Adopts NativeSelect for the three date/post/currency selects and the split
editor's post picker, and Segmented for the one/many and
percentages/amounts switches. The currency select now matches the Total
input beside it exactly: same height, radius, border and text indent.

The rest is hit areas and edges:

- "set exact date" / "use the month only" were bare buttons with no padding
  at all — a 15px target under a 36px field, unhittable on a phone. Now a
  24px box, with a negative margin so the text still lines up with the
  field's left edge.
- The split row's `remove` and the plan's `remove plan` ran past the
  dialog's right padding; both now end on it.
- The bulk-entry remove was a `×` glyph in a 20px box. It uses
  lucide's X, the icon family the dialog's own close button already uses.
- The split editor's post select gains `min-w-0` via NativeSelect, so
  `flex-1` can shrink below the widest option — the actual cause of the
  dialog padding bug fixed in the previous commit.
- The "rounding" radio label gets a real vertical hit area.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Lucas WintherandClaude Opus 5 committed 2026-09-02 22:58:44 +02:00
1 parent 85ba899059
commit f6be0c8439
4 files changed
+89 -58

No files matched your search

+24 -18
View File
@@ -2,7 +2,9 @@ import { Button } from "@/components/ui/button";
import { useDataset } from "../hooks/useDataset.ts";
import { digitsFor } from "../../domain/currencies.ts";
import { Input } from "@/components/ui/input";
import { NativeSelect } from "@/components/ui/native-select";
import { Label } from "@/components/ui/label";
import { Segmented } from "./Segmented.tsx";
import { formatAmount } from "../format.ts";
import type { PurchaseDraft, SplitDraft } from "../purchaseForm.ts";
import { splitBalance } from "../purchaseForm.ts";
@@ -39,25 +41,24 @@ export function SplitEditor({ draft, posts, onChange }: Props) {
<fieldset className="space-y-3">
<div className="flex items-center justify-between">
<Label>Split across posts</Label>
<div className="flex gap-1 text-xs">
{(["percent", "fixed"] as const).map((mode) => (
<Button
key={mode}
type="button"
size="sm"
variant={draft.splitMode === mode ? "default" : "outline"}
onClick={() => onChange({ ...draft, splitMode: mode })}
>
{mode === "percent" ? "Percentages" : "Amounts"}
</Button>
))}
</div>
<Segmented
label="Split by"
value={draft.splitMode}
onChange={(splitMode) => onChange({ ...draft, splitMode })}
options={[
{ value: "percent", label: "Percentages" },
{ value: "fixed", label: "Amounts" },
]}
/>
</div>
{draft.splits.map((split, index) => (
<div key={index} className="flex items-center gap-2">
<select
className="h-9 flex-1 rounded border bg-background px-2 text-sm"
{/* `min-w-0` comes from NativeSelect. Without it `flex-1` could not
shrink below the widest option, and this row's min-content width
was what pushed the whole dialog past its own padding. */}
<NativeSelect
className="flex-1"
value={split.postId}
onChange={(event) => updateSplit(index, { postId: event.target.value })}
>
@@ -67,7 +68,7 @@ export function SplitEditor({ draft, posts, onChange }: Props) {
{post.name}
</option>
))}
</select>
</NativeSelect>
<Input
type="number"
@@ -80,10 +81,14 @@ export function SplitEditor({ draft, posts, onChange }: Props) {
/>
<span className="w-10 text-xs text-muted-foreground">{unit}</span>
<label className="flex items-center gap-1 text-xs" title="This post absorbs rounding">
<label
className="flex shrink-0 items-center gap-1.5 rounded-md py-1.5 text-xs"
title="This post absorbs rounding"
>
<input
type="radio"
name="absorber"
className="size-3.5"
checked={split.absorbsRemainder}
onChange={() => setAbsorber(index)}
/>
@@ -92,8 +97,9 @@ export function SplitEditor({ draft, posts, onChange }: Props) {
<Button
type="button"
size="sm"
size="xs"
variant="ghost"
className="-mr-2 shrink-0"
disabled={draft.splits.length === 1}
onClick={() =>
onChange({