Lucas WintherandClaude Opus 5
042bc8597d
requireStartDateGranularity (store/actions.ts) and its import-path twin (export/json.ts) checked date SHAPE with a regex, not date VALIDITY, so "2026-09-31" (September has 30 days) passed both and threw later out of foldBalances instead of at the write boundary. isValidStartDate (RecurringSection.tsx) had the same hole for a day-shaped value under everyNMonths. Separately, monthOf's regex (domain/months.ts) was unanchored at the end, so "2026-091" was silently read as September 2026. Route day-shaped values through toDayOrdinal and month-shaped values through monthOf (now anchored to accept only "YYYY-MM" or "YYYY-MM-DD" in full, never a prefix) at all three write boundaries, converting whatever they throw into each file's own error style. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
71 lines
2.3 KiB
TypeScript
71 lines
2.3 KiB
TypeScript
import type { IsoDate, MonthId } from "./types.ts";
|
|
|
|
function parse(id: MonthId): { year: number; month: number } {
|
|
const match = /^(\d{4})-(\d{2})$/.exec(id);
|
|
if (!match) throw new Error(`Invalid MonthId: ${id}`);
|
|
const year = Number(match[1]);
|
|
const month = Number(match[2]);
|
|
if (month < 1 || month > 12) throw new Error(`Invalid MonthId: ${id}`);
|
|
return { year, month };
|
|
}
|
|
|
|
function format(year: number, month: number): MonthId {
|
|
return `${String(year).padStart(4, "0")}-${String(month).padStart(2, "0")}`;
|
|
}
|
|
|
|
/** Months since year 0. Avoids Date and therefore avoids timezones entirely. */
|
|
function toOrdinal(id: MonthId): number {
|
|
const { year, month } = parse(id);
|
|
return year * 12 + (month - 1);
|
|
}
|
|
|
|
function fromOrdinal(ordinal: number): MonthId {
|
|
return format(Math.floor(ordinal / 12), (ordinal % 12) + 1);
|
|
}
|
|
|
|
// Anchored at both ends: "YYYY-MM" or "YYYY-MM-DD" only, never a prefix of
|
|
// something longer. Dual acceptance (with or without a day) is deliberate and
|
|
// load-bearing — do not narrow it to one form. An unanchored match once let
|
|
// "2026-091" through as September 2026, silently dropping the trailing "1".
|
|
const MONTH_OF_DATE = /^(\d{4})-(\d{2})(?:-\d{2})?$/;
|
|
|
|
export function monthOf(date: IsoDate): MonthId {
|
|
const match = MONTH_OF_DATE.exec(date);
|
|
if (!match) throw new Error(`Invalid IsoDate: ${date}`);
|
|
const month = Number(match[2]);
|
|
if (month < 1 || month > 12) throw new Error(`Invalid IsoDate: ${date}`);
|
|
return `${match[1]}-${match[2]}`;
|
|
}
|
|
|
|
export function yearOf(id: MonthId): number {
|
|
return parse(id).year;
|
|
}
|
|
|
|
export function addMonths(id: MonthId, count: number): MonthId {
|
|
return fromOrdinal(toOrdinal(id) + count);
|
|
}
|
|
|
|
export function nextMonth(id: MonthId): MonthId {
|
|
return addMonths(id, 1);
|
|
}
|
|
|
|
export function prevMonth(id: MonthId): MonthId {
|
|
return addMonths(id, -1);
|
|
}
|
|
|
|
export function compareMonths(a: MonthId, b: MonthId): number {
|
|
return toOrdinal(a) - toOrdinal(b);
|
|
}
|
|
|
|
export function monthRange(from: MonthId, to: MonthId): MonthId[] {
|
|
const start = toOrdinal(from);
|
|
const end = toOrdinal(to);
|
|
const out: MonthId[] = [];
|
|
for (let i = start; i <= end; i++) out.push(fromOrdinal(i));
|
|
return out;
|
|
}
|
|
|
|
export function monthsOfYear(year: number): MonthId[] {
|
|
return monthRange(format(year, 1), format(year, 12));
|
|
}
|