Lucas WintherandClaude Opus 5
e6da85e7f9
Two defects behind "the new version is ready" not going away.
1. THE WORKER NEVER INSTALLED — in any environment, ever.
install did `cache.addAll([...PRECACHE, SHELL])`. PRECACHE is derived from
the build's own outputs, which already contain index.html, and SHELL is
index.html again. addAll() rejects the ENTIRE install on a duplicate
request:
InvalidStateError: Cache.addAll(): duplicate requests (.../index.html)
So install failed on every load, the worker went redundant, and nothing
ever activated. Registration itself succeeds and the failure is inside the
install event, so nothing surfaced it — which is why offline behaviour was
listed as "never verified" rather than "broken". All 11 precached URLs
return 200; the list was the only fault. Deduping now lives in
src/swPrecache.ts, at the point of use, so no future addition to either
list can reintroduce it.
Verified in a real browser for the first time: the worker installs,
activates, claims the page, and caches 11 entries. A rebuild is then
detected, the prompt appears, clicking Reload applies it, stale caches are
dropped and the prompt does not return.
2. THE DEV WORKER IGNORED THE LIFECYCLE — my own regression, from 53707b1.
That commit made the dev server serve an inert sw.js to silence a MIME
error. Inert included the lifecycle: no skipWaiting, no clients.claim, no
message handler. A worker like that can sit in `waiting` forever and can
never be applied, so the prompt returns on every load and the Reload button
cannot possibly clear it. This is the likeliest cause of the reported
symptom, since with defect 1 a production build could never have shown that
prompt at all. The dev worker still caches nothing — that would fight HMR —
but now honours install, activate and SKIP_WAITING.
3. applyUpdate RACED ITS OWN RELOAD — real, measured, but not reproducible on
demand, so it is hardening rather than a proven fix.
It posted SKIP_WAITING and called window.location.reload() on the next
line. Measured in Chrome: at that instant the new worker was still
`installed` and the controller had NOT changed — it changed 2 ms later. The
window is wider in practice because activate deletes every stale cache
before claiming clients. When the reload wins, the reloaded page still finds
registration.waiting and shows the prompt again. It now waits for
controllerchange, with a timeout backstop so a worker that ignores
SKIP_WAITING cannot leave the button dead. The sequencing is pure and
tested (src/ui/swUpdate.ts): listener attached before the message, reload
exactly once, unsubscribed after.
Tooling: scripts/screenshot.ts gains --profile (a fresh Chrome profile has no
registered worker, so nothing stateful across loads could be reproduced at all)
and --eval-after-file (observe a flow that ends in a navigation from the other
side of it).
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
54 lines
1.9 KiB
TypeScript
54 lines
1.9 KiB
TypeScript
import { test, expect, describe } from "bun:test";
|
|
import { precacheUrls } from "./swPrecache.ts";
|
|
|
|
describe("the service worker's precache list", () => {
|
|
/**
|
|
* The bug this exists for: `cache.addAll()` rejects the WHOLE install with
|
|
* InvalidStateError if the list contains the same request twice. The build's
|
|
* precache list is derived from its own outputs, which already include
|
|
* index.html, and the worker then appended the shell — index.html again. So
|
|
* install failed every time, the worker went redundant, and no service
|
|
* worker ever activated. Nothing reported it: registration itself succeeds,
|
|
* and the failure is inside the install event.
|
|
*/
|
|
test("the shell is not repeated when the build already emitted it", () => {
|
|
expect(precacheUrls(["/index.html", "/index-abc.js"], "/index.html")).toEqual([
|
|
"/index.html",
|
|
"/index-abc.js",
|
|
]);
|
|
});
|
|
|
|
test("the shell is added when the build did not emit it", () => {
|
|
expect(precacheUrls(["/index-abc.js"], "/index.html")).toEqual([
|
|
"/index-abc.js",
|
|
"/index.html",
|
|
]);
|
|
});
|
|
|
|
test("any duplicate is removed, not just the shell", () => {
|
|
expect(precacheUrls(["/a.js", "/b.css", "/a.js"], "/index.html")).toEqual([
|
|
"/a.js",
|
|
"/b.css",
|
|
"/index.html",
|
|
]);
|
|
});
|
|
|
|
test("order is preserved, so the shell is not fetched before the assets", () => {
|
|
expect(precacheUrls(["/z.js", "/a.css"], "/index.html")).toEqual([
|
|
"/z.js",
|
|
"/a.css",
|
|
"/index.html",
|
|
]);
|
|
});
|
|
|
|
test("a subpath deploy is not a special case", () => {
|
|
expect(
|
|
precacheUrls(["/budget2.0/index.html", "/budget2.0/x.js"], "/budget2.0/index.html"),
|
|
).toEqual(["/budget2.0/index.html", "/budget2.0/x.js"]);
|
|
});
|
|
|
|
test("an empty build still precaches the shell", () => {
|
|
expect(precacheUrls([], "/index.html")).toEqual(["/index.html"]);
|
|
});
|
|
});
|