Files
budget2.0/src/ui/components/BulkLines.tsx
T
Lucas WintherandClaude Opus 5 8d2b2ca881 feat(money): one decimals setting for the dataset, not one per currency
`Settings.digits` replaces `CurrencyDef.digits`. Every amount rounds to it,
whatever its currency, and `digitsFor` is gone: the sixteen call sites read the
setting, and the domain functions that took a currency table purely to look
digits up take a `digits: number` instead. Schema 6.

The owner asked for this with the cost in front of them, and the cost is real:
a dataset mixing minor units cannot be described any more. Yen at 0 beside
kroner at 2 has no correct global value — 2 gives ¥1234.56, an amount yen
cannot represent; 0 rounds 49.95 DKK to 50 and drifts the carry from the bank.
Nothing in the app warns. docs/specs/2026-09-02-global-decimals-design.md
argues it in full, including what re-adding a per-currency override would take,
and AGENTS.md §1 now says not to reintroduce one without revisiting the
decision.

The 5 -> 6 step takes the MAXIMUM of the per-currency digits, not the base
currency's. A dataset holding a three-decimal currency already has
three-decimal amounts in it, and adopting the base's 2 would truncate the next
edit of one; the maximum can only keep more precision, never less. On every
dataset this app has written all four currencies record 2, so nothing rounds
differently than before.

Changing the setting does not rewrite stored amounts. 49.95 stays 49.95 and
shows as 50; totals recompute at the new precision. Rewriting each Money is a
destructive whole-dataset write, which §1 owes a backup export first, and it is
lossy one way.

Display turned out to be the hole in the plan. src/ui/format.ts pinned
minimumFractionDigits: 2 in a module-level Intl.NumberFormat, so it never read
the dataset at all — equally broken under per-currency digits, where a JPY
rendered "3,333.00", so a pre-existing gap rather than a regression. Shipping a
Settings control that display ignores would look broken at 0 and be lossy at 3,
hiding precision the dataset holds. So format.ts takes digits like roundMoney
does, useMoneyFormat() binds them for the 64 call sites, and postRowCells takes
the formatter as an argument because it is a plain helper, not a component.

currencyDigits.test.ts is rewritten rather than deleted. Driving a dataset at
ZERO decimals through rounding, both FX directions, both split modes, plan
division, the fold and the month view still tells a real implementation from
one assuming 2 — it just cannot prove per-currency flow, because there is none.
It also asserts that raising the setting to 2 changes what the fold produces.

Verified in Chrome, not only in tests: a v5 dataset with digits 2/0/3 written
straight into IndexedDB migrates to a setting of 3, the table loses its
Decimals column, and editing the control persists schema 6 with digits stripped
from each currency and income left at 20000.55. The same month reads 600/206 at
zero decimals and 600.000/205.561 at three, so the figures recompute rather
than merely reformat.

Not verified here: the .ods in a real spreadsheet.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
2026-09-03 03:12:14 +02:00

143 lines
4.9 KiB
TypeScript

import { useRef } from "react";
import { XIcon } from "lucide-react";
import { useDataset } from "../hooks/useDataset.ts";
import { Button } from "@/components/ui/button";
import { Input } from "@/components/ui/input";
import { Label } from "@/components/ui/label";
import { useMoneyFormat } from "../hooks/useMoneyFormat.ts";
import {
bulkTotal,
isBlankLine,
withTrailingBlank,
type BulkDraft,
type BulkLine,
} from "../bulkEntry.ts";
interface Props {
draft: BulkDraft;
onChange: (next: BulkDraft) => void;
}
/**
* The row list for fast entry: description, amount, note — and nothing else in
* the tab order, so Tab walks the fields and only the fields.
*
* The list always ends in one blank row, appended as soon as the last row is
* filled, so Tab flows into a new line with no special case and new rows appear
* on touch devices too. That is why there is no "Add line" button.
*/
export function BulkLines({ draft, onChange }: Props) {
const digits = useDataset().settings.digits;
const fmt = useMoneyFormat();
const descriptionRefs = useRef<Array<HTMLInputElement | null>>([]);
const noteRefs = useRef<Array<HTMLInputElement | null>>([]);
function update(index: number, changes: Partial<BulkLine>) {
onChange(
withTrailingBlank({
...draft,
lines: draft.lines.map((line, i) => (i === index ? { ...line, ...changes } : line)),
}),
);
}
function removeLine(index: number) {
const remaining = draft.lines.filter((_, i) => i !== index);
onChange(withTrailingBlank({ ...draft, lines: remaining }));
// Land on the previous row's last field, which is where the user came from.
if (index > 0) requestAnimationFrame(() => noteRefs.current[index - 1]?.focus());
}
const filledCount = draft.lines.filter((line) => !isBlankLine(line)).length;
return (
<fieldset className="space-y-2">
<div className="flex items-center justify-between">
<Label>Lines</Label>
<span className="text-xs text-muted-foreground">
Tab through the fields; a new line opens as you fill the last one
</span>
</div>
<div className="max-h-72 space-y-1 overflow-y-auto pr-1">
{draft.lines.map((line, index) => (
<div key={index} className="group flex items-center gap-2">
<span className="w-5 shrink-0 text-right text-xs text-muted-foreground">
{index + 1}
</span>
<Input
ref={(el) => {
descriptionRefs.current[index] = el;
}}
className="h-8 flex-1"
placeholder="What was it?"
value={line.description}
onChange={(event) => {
const description = event.target.value;
update(index, { description });
}}
onKeyDown={(event) => {
// Backspace in an already-empty description removes the row.
if (
event.key === "Backspace" &&
line.description === "" &&
draft.lines.length > 1
) {
event.preventDefault();
removeLine(index);
}
}}
/>
<Input
className="font-money h-8 w-24"
type="number"
step="0.01"
placeholder="0.00"
value={line.amount === 0 ? "" : line.amount}
onChange={(event) => {
const amount = Number(event.target.value) || 0;
update(index, { amount });
}}
/>
<Input
ref={(el) => {
noteRefs.current[index] = el;
}}
className="h-8 w-40"
placeholder="Note (optional)"
value={line.note}
onChange={(event) => {
const note = event.target.value;
update(index, { note });
}}
/>
{/* Was a bare `&times;` in a 20px-wide box: a text glyph doing an
icon's job, at a size nothing could hit. lucide's X is the icon
family the dialog's own close button already uses. */}
<Button
type="button"
tabIndex={-1}
variant="ghost"
size="icon-xs"
aria-label={`Remove line ${index + 1}`}
className="shrink-0 text-muted-foreground opacity-0 transition-opacity group-hover:opacity-100 group-focus-within:opacity-100 hover:text-overspend"
onClick={() => removeLine(index)}
>
<XIcon />
</Button>
</div>
))}
</div>
<p className="text-right text-xs text-muted-foreground">
{filledCount} line{filledCount === 1 ? "" : "s"} &middot;{" "}
<span className="font-money">{fmt.money(bulkTotal(draft, digits), draft.currency)}</span>
</p>
</fieldset>
);
}