Lucas WintherandClaude Opus 5
8d2b2ca881
`Settings.digits` replaces `CurrencyDef.digits`. Every amount rounds to it, whatever its currency, and `digitsFor` is gone: the sixteen call sites read the setting, and the domain functions that took a currency table purely to look digits up take a `digits: number` instead. Schema 6. The owner asked for this with the cost in front of them, and the cost is real: a dataset mixing minor units cannot be described any more. Yen at 0 beside kroner at 2 has no correct global value — 2 gives ¥1234.56, an amount yen cannot represent; 0 rounds 49.95 DKK to 50 and drifts the carry from the bank. Nothing in the app warns. docs/specs/2026-09-02-global-decimals-design.md argues it in full, including what re-adding a per-currency override would take, and AGENTS.md §1 now says not to reintroduce one without revisiting the decision. The 5 -> 6 step takes the MAXIMUM of the per-currency digits, not the base currency's. A dataset holding a three-decimal currency already has three-decimal amounts in it, and adopting the base's 2 would truncate the next edit of one; the maximum can only keep more precision, never less. On every dataset this app has written all four currencies record 2, so nothing rounds differently than before. Changing the setting does not rewrite stored amounts. 49.95 stays 49.95 and shows as 50; totals recompute at the new precision. Rewriting each Money is a destructive whole-dataset write, which §1 owes a backup export first, and it is lossy one way. Display turned out to be the hole in the plan. src/ui/format.ts pinned minimumFractionDigits: 2 in a module-level Intl.NumberFormat, so it never read the dataset at all — equally broken under per-currency digits, where a JPY rendered "3,333.00", so a pre-existing gap rather than a regression. Shipping a Settings control that display ignores would look broken at 0 and be lossy at 3, hiding precision the dataset holds. So format.ts takes digits like roundMoney does, useMoneyFormat() binds them for the 64 call sites, and postRowCells takes the formatter as an argument because it is a plain helper, not a component. currencyDigits.test.ts is rewritten rather than deleted. Driving a dataset at ZERO decimals through rounding, both FX directions, both split modes, plan division, the fold and the month view still tells a real implementation from one assuming 2 — it just cannot prove per-currency flow, because there is none. It also asserts that raising the setting to 2 changes what the fold produces. Verified in Chrome, not only in tests: a v5 dataset with digits 2/0/3 written straight into IndexedDB migrates to a setting of 3, the table loses its Decimals column, and editing the control persists schema 6 with digits stripped from each currency and income left at 20000.55. The same month reads 600/206 at zero decimals and 600.000/205.561 at three, so the figures recompute rather than merely reformat. Not verified here: the .ods in a real spreadsheet. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
38 lines
1.4 KiB
TypeScript
38 lines
1.4 KiB
TypeScript
import { useMemo } from "react";
|
|
import { useDataset } from "./useDataset.ts";
|
|
import {
|
|
formatAmount,
|
|
formatMoney,
|
|
formatSignedAmount,
|
|
formatSignedMoney,
|
|
} from "../format.ts";
|
|
import type { Currency } from "../../domain/types.ts";
|
|
|
|
/**
|
|
* The four money formatters, bound to the dataset's decimals setting.
|
|
*
|
|
* A hook rather than digits threaded through props: display is needed at every
|
|
* depth — a table cell, a hint under an input, a stat tile — and `settings.digits`
|
|
* is one value for the whole dataset, so a component deep in a tree asking for
|
|
* it directly is honest rather than a shortcut. The underlying functions in
|
|
* `../format.ts` still take digits explicitly, which is what keeps them
|
|
* testable without a React tree.
|
|
*/
|
|
export function useMoneyFormat() {
|
|
const digits = useDataset().settings.digits;
|
|
return useMemo(
|
|
() => ({
|
|
digits,
|
|
amount: (amount: number) => formatAmount(amount, digits),
|
|
money: (amount: number, currency: Currency) => formatMoney(amount, currency, digits),
|
|
signedAmount: (amount: number) => formatSignedAmount(amount, digits),
|
|
signedMoney: (amount: number, currency: Currency) =>
|
|
formatSignedMoney(amount, currency, digits),
|
|
}),
|
|
[digits],
|
|
);
|
|
}
|
|
|
|
/** What `useMoneyFormat` returns, for a component that takes it as a prop. */
|
|
export type MoneyFormat = ReturnType<typeof useMoneyFormat>;
|