Lucas WintherandClaude Opus 5
ae34f9519d
Implements docs/superpowers/specs/2026-09-02-fast-entry-refinements-design.md.
Three changes shipped together because they share one tab order.
Bulk rows are description -> amount -> note, and nothing else is a tab stop.
The list always ends in exactly one blank row, appended as soon as the last
row is filled, so Tab flows into a new line with no special case and new rows
appear on touch too. The Add-line button is gone; the per-row remove button is
now a hover/focus x with tabIndex={-1}, and Backspace in an empty description
removes the row and lands on the previous row's note.
Purchases no longer demand a day. `date` accepts "2026-09" as well as
"2026-09-14"; entry defaults to the month, with an opt-in "set exact date"
link. No migration: monthOf() already parsed both shapes, verified before
choosing this over splitting the field into month + optional day, which would
have meant a schema migration in the browser against the user's only copy of
their data for an identical outcome.
Notes are an optional field on Purchase, in both entry forms and shown beside
the description in the month lists. Empty notes are omitted rather than stored
as "", so absent stays absent.
Also closes a pre-existing gap the spec surfaced: the JSON importer never
validated purchase.date, so a malformed date passed import and threw later
inside the balance fold. It is now rejected at the boundary, with out-of-range
months and days covered.
A row holding only a note is deliberately NOT blank: it asks for the missing
description and amount rather than being silently discarded.
Keyboard behaviour - tab traversal, Backspace-to-remove, focus after append -
cannot be verified in this environment and needs confirming in a browser.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
111 lines
3.3 KiB
TypeScript
111 lines
3.3 KiB
TypeScript
// src/domain/months.test.ts
|
|
import { test, expect, describe } from "bun:test";
|
|
import {
|
|
monthOf,
|
|
nextMonth,
|
|
prevMonth,
|
|
compareMonths,
|
|
monthRange,
|
|
monthsOfYear,
|
|
addMonths,
|
|
yearOf,
|
|
} from "./months.ts";
|
|
|
|
test("monthOf extracts the month from an ISO date", () => {
|
|
expect(monthOf("2026-09-14")).toBe("2026-09");
|
|
});
|
|
|
|
describe("month stepping", () => {
|
|
test("nextMonth crosses the year boundary", () => {
|
|
expect(nextMonth("2026-11")).toBe("2026-12");
|
|
expect(nextMonth("2026-12")).toBe("2027-01");
|
|
});
|
|
|
|
test("prevMonth crosses the year boundary", () => {
|
|
expect(prevMonth("2026-01")).toBe("2025-12");
|
|
});
|
|
|
|
test("addMonths handles multi-year spans in both directions", () => {
|
|
expect(addMonths("2026-09", 6)).toBe("2027-03");
|
|
expect(addMonths("2026-09", -12)).toBe("2025-09");
|
|
expect(addMonths("2026-09", 0)).toBe("2026-09");
|
|
});
|
|
});
|
|
|
|
test("compareMonths orders chronologically", () => {
|
|
expect(compareMonths("2026-01", "2026-02")).toBeLessThan(0);
|
|
expect(compareMonths("2027-01", "2026-12")).toBeGreaterThan(0);
|
|
expect(compareMonths("2026-05", "2026-05")).toBe(0);
|
|
});
|
|
|
|
describe("monthRange", () => {
|
|
test("is inclusive of both ends", () => {
|
|
expect(monthRange("2026-11", "2027-01")).toEqual([
|
|
"2026-11",
|
|
"2026-12",
|
|
"2027-01",
|
|
]);
|
|
});
|
|
|
|
test("returns a single month when both ends match", () => {
|
|
expect(monthRange("2026-03", "2026-03")).toEqual(["2026-03"]);
|
|
});
|
|
|
|
test("returns empty when `to` precedes `from`", () => {
|
|
expect(monthRange("2026-05", "2026-04")).toEqual([]);
|
|
});
|
|
});
|
|
|
|
test("monthsOfYear returns twelve padded months", () => {
|
|
const months = monthsOfYear(2026);
|
|
expect(months).toHaveLength(12);
|
|
expect(months[0]).toBe("2026-01");
|
|
expect(months[11]).toBe("2026-12");
|
|
});
|
|
|
|
test("yearOf parses the year", () => {
|
|
expect(yearOf("2026-09")).toBe(2026);
|
|
});
|
|
|
|
describe("month range validation", () => {
|
|
test("yearOf rejects out-of-range month 13", () => {
|
|
expect(() => yearOf("2026-13")).toThrow(/2026-13/);
|
|
});
|
|
|
|
test("yearOf rejects out-of-range month 00", () => {
|
|
expect(() => yearOf("2026-00")).toThrow(/2026-00/);
|
|
});
|
|
|
|
test("monthOf rejects out-of-range month 13 from IsoDate", () => {
|
|
expect(() => monthOf("2026-13-01")).toThrow(/2026-13-01/);
|
|
});
|
|
|
|
test("monthOf rejects out-of-range month 00 from IsoDate", () => {
|
|
expect(() => monthOf("2026-00-15")).toThrow(/2026-00-15/);
|
|
});
|
|
|
|
test("valid boundary month 01 works", () => {
|
|
expect(yearOf("2026-01")).toBe(2026);
|
|
expect(monthOf("2026-01-01")).toBe("2026-01");
|
|
});
|
|
|
|
test("valid boundary month 12 works", () => {
|
|
expect(yearOf("2026-12")).toBe(2026);
|
|
expect(monthOf("2026-12-31")).toBe("2026-12");
|
|
});
|
|
});
|
|
|
|
// The optional-day feature stores "YYYY-MM" when a purchase has no specific
|
|
// day. monthOf already handled that incidentally; this pins it, because the
|
|
// whole approach depends on it rather than on a migration.
|
|
test("monthOf accepts a month-only date as well as a full one", () => {
|
|
expect(monthOf("2026-09-14")).toBe("2026-09");
|
|
expect(monthOf("2026-09")).toBe("2026-09");
|
|
});
|
|
|
|
test("monthOf still rejects out-of-range and malformed month-only values", () => {
|
|
expect(() => monthOf("2026-13")).toThrow(/2026-13/);
|
|
expect(() => monthOf("2026-00")).toThrow(/2026-00/);
|
|
expect(() => monthOf("2026-9")).toThrow(/2026-9/);
|
|
});
|