Lucas WintherandClaude Opus 5
bb3c661ef6
Sub-project 1 of the redesign. The diagnosis that shaped it: a design system already existed and was never wired up. src/index.css defined --paper, --ink and a muted teal with a contract document behind them, while the app painted itself with shadcn's default white and near-black. Those tokens reached the screen in exactly two places — the carry meter and the +/- number colours. TOKENS. Two layers: --budget-* is the app's own vocabulary, defined once per theme, and shadcn's whole variable set points at it, so every primitive inherits both themes rather than being fought. Light is cool paper with ink navy; dark is deep slate, never pure black, because a black ground makes the hairlines and the carry meter float. The brand teal is --primary, NOT --accent. That is precisely what the old bug got wrong: shadcn's --accent is a subtle hover BACKGROUND paired with --accent-foreground, so a saturated colour there turns every hover into a coloured slab with unreadable text. src/cssPairs.test.ts now makes the rule mechanical — redefining either half of a shadcn pair without the other fails the build, in any block. CONTRAST was computed, not eyeballed: the weakest text pair is 5.50:1 against a 4.5:1 requirement, and field borders clear the 3:1 non-text requirement on both of their backgrounds. Verified afterwards by reading the tokens back out of the live browser in both themes rather than trusting the arithmetic. TYPE. Inter and JetBrains Mono, self-hosted (SIL OFL, licences committed alongside), latin + latin-ext only. Not in index.css: Bun's CSS bundler resolves every url() from disk and inlines woff2 as base64 — relative or absolute, and a "file" loader override does not stop it — which made the stylesheet 303 KB of render-blocking bytes and defeated the unicode-range subsetting entirely. They are injected at boot from one definition instead, which is the only arrangement identical in dev and in a subpath build. THEME TOGGLE cycles system / light / dark, remembers the choice in localStorage (a per-device display preference does not belong in the exported budget), keeps following the OS while set to "system", and is applied by a tiny inline script before first paint so a dark-theme user never sees a white flash. Every storage access is wrapped: localStorage throws outright in some configurations, and a theme preference must never stop the app booting. A REGRESSION I CAUSED AND CAUGHT: renaming --rule to --budget-rule silently killed the carry meter. An undefined custom property inside linear-gradient() does not warn, does not throw and does not fall back — the declaration is invalid, so the element paints nothing. It looked like a missing feature. Only pixel-sampling a screenshot found it. src/ui/cssTokens.test.ts now fails if any TypeScript file references a token src/index.css does not define. Also: one Section/Stat card treatment applied across month, year, summary and settings; quiet uppercase table headers; row hover; the rule-editing and purchase-row actions revealed on hover instead of six always-on links; a scroll fade on the year matrix so it reads as "more to come" rather than clipped; and "September 2026" instead of "2026-09" as the month heading. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
49 lines
1.9 KiB
TypeScript
49 lines
1.9 KiB
TypeScript
import { test, expect, describe } from "bun:test";
|
|
import { FONT_FILES, buildFontCss } from "./fontCss.ts";
|
|
|
|
describe("the font stylesheet", () => {
|
|
test("every url is absolute from the deploy base", () => {
|
|
const css = buildFontCss("/budget2.0/");
|
|
const urls = [...css.matchAll(/url\("([^"]+)"\)/g)].map((m) => m[1]);
|
|
expect(urls).toEqual(FONT_FILES.map((f) => `/budget2.0/fonts/${f}`));
|
|
});
|
|
|
|
test("a root deploy is not a special case", () => {
|
|
const urls = [...buildFontCss("/").matchAll(/url\("([^"]+)"\)/g)].map((m) => m[1]);
|
|
expect(urls).toEqual(FONT_FILES.map((f) => `/fonts/${f}`));
|
|
});
|
|
|
|
/**
|
|
* Relative urls are what this must never emit. The stylesheet is served from
|
|
* the deploy root but the DOCUMENT can be several segments deep
|
|
* (/budget2.0/month/2026-09), and a relative font url resolves against
|
|
* whichever of the two the browser used — silently 404ing on deep routes.
|
|
*/
|
|
test("no url is relative", () => {
|
|
const css = buildFontCss("/budget2.0/");
|
|
expect(css).not.toContain('url("./');
|
|
expect(css).not.toContain('url("fonts/');
|
|
});
|
|
|
|
test("each face declares a weight range, not a single weight", () => {
|
|
// Both faces are variable; one file must cover the whole scale.
|
|
const css = buildFontCss("/");
|
|
expect(css).toContain("font-weight: 100 900");
|
|
expect(css).toContain("font-weight: 400 700");
|
|
expect(css.match(/@font-face/g)).toHaveLength(FONT_FILES.length);
|
|
});
|
|
|
|
test("every declared file is actually committed", async () => {
|
|
for (const file of FONT_FILES) {
|
|
expect(await Bun.file(`src/fonts/${file}`).exists()).toBe(true);
|
|
}
|
|
});
|
|
|
|
test("the licences travel with the fonts, as the OFL requires", async () => {
|
|
for (const licence of ["OFL-Inter.txt", "OFL-JetBrainsMono.txt"]) {
|
|
const text = await Bun.file(`src/fonts/${licence}`).text();
|
|
expect(text).toContain("SIL Open Font License");
|
|
}
|
|
});
|
|
});
|