lucasw89/gacha-event-tracker
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(game8): let an h4 fence a section off without naming one

Browse Source 
Game8 uses h4 for two opposite jobs. Persona 5 hides its entire finished
back catalogue behind nothing but an `<h4>Finished Events</h4>` inside a
collapsed accordion, so a reader blind to h4 sees one uninterrupted run of
tables and would publish fifty dead events. Genshin uses h4 the other way
round, for sub-headings *within* a single event ("Availability Period",
"Characters & Rewards for this Test Run").

So h4 now gates sections but never names one: an unrecognised h4 leaves
the current event title alone, where an unrecognised h2 or h3 still sets
it. Letting one claim the title renames "Character Test Runs" to the
label sitting above its own date table, which the Genshin fixture catches.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This commit is contained in:
Lucas Winther
2026-08-17 17:20:31 +02:00
co-authored by Claude Opus 5
parent 2b0aa6bd0f
commit 243c7d70dd
2 changed files with 25 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ingest/html.ts
+12 -3
View File
@@ -79,11 +79,18 @@ export interface ParagraphNode {
export type DocNode =
| { kind: "h2"; text: string }
| { kind: "h3"; text: string }
| { kind: "h4"; text: string }
| TableNode
| ParagraphNode;
/**
* Walk a document in source order, yielding h2/h3 headings and tables.
* Walk a document in source order, yielding h2/h3/h4 headings and tables.
*
* h4 matters because it is sometimes the only thing separating a live table
* from a finished one — Game8's Persona 5 page puts its whole back catalogue
* under an `<h4>Finished Events</h4>` inside a collapsed accordion. A reader
* blind to h4 sees one uninterrupted run of tables and cannot tell where the
* live section stops.
*
* Pure: no network, no clock. Given identical input it always yields identical
* output, which is what makes fixture tests meaningful.
@@ -93,14 +100,16 @@ export function scanDocument(rawHtml: string): DocNode[] {
const nodes: DocNode[] = [];
const re =
/<h2\b[^>]*>([\s\S]*?)<\/h2>|<h3\b[^>]*>([\s\S]*?)<\/h3>|<table\b[^>]*>([\s\S]*?)<\/table>|<p\b[^>]*>([\s\S]*?)<\/p>/gi;
/<h2\b[^>]*>([\s\S]*?)<\/h2>|<h3\b[^>]*>([\s\S]*?)<\/h3>|<h4\b[^>]*>([\s\S]*?)<\/h4>|<table\b[^>]*>([\s\S]*?)<\/table>|<p\b[^>]*>([\s\S]*?)<\/p>/gi;
for (const m of html.matchAll(re)) {
const [whole, h2, h3, table, p] = m;
const [whole, h2, h3, h4, table, p] = m;
if (h2 !== undefined) {
nodes.push({ kind: "h2", text: text(h2) });
} else if (h3 !== undefined) {
nodes.push({ kind: "h3", text: text(h3) });
} else if (h4 !== undefined) {
nodes.push({ kind: "h4", text: text(h4) });
} else if (table !== undefined) {
nodes.push(readTable(table));
} else if (p !== undefined) {