Resolve an occurrence back to the rule behind it

The detail sheet looked its record up by the row's id. For an occurrence
that id carries a #date suffix and is not a key in the store, so `own` came
back undefined and the edit and delete buttons vanished on every recurring
row — and a save would have reached editEvent with an id it could not find
and quietly done nothing.

The suffix is deliberate: marks key off the occurrence so each time round
carries its own completion. There is still only one record to edit.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This commit is contained in:
Lucas Winther
2026-08-28 05:04:39 +02:00
co-authored by Claude Opus 5
parent 4f53b7e153
commit 60041134ee
3 changed files with 68 additions and 13 deletions
+33
View File
@@ -10,6 +10,7 @@ import {
mintCustomEventId,
mintCustomGameId,
precisionOf,
recordFor,
RESERVED_ID_SEGMENTS,
type CustomGames,
} from "../src/shared/custom.ts";
@@ -607,3 +608,35 @@ describe("expanding rules into rows", () => {
expect(rows).toEqual([]);
});
});
describe("recordFor", () => {
const rule = ownEvent({
id: "myevent:k3f9qa2m01",
startsAt: new Date("2026-09-01T09:00:00").toISOString(),
startPrecision: "exact",
endsAt: new Date("2026-09-08T09:00:00").toISOString(),
endPrecision: "exact",
repeat: { unit: "weeks", interval: 2, until: null },
});
const store = { [rule.id]: rule };
test("an occurrence row finds the rule behind it", () => {
// Marks key off the occurrence — that is what gives each time round its own
// completion — but the record to edit is the rule. Without this the detail
// sheet looks up a key that does not exist and edit and delete vanish.
expect(recordFor(store, "myevent:k3f9qa2m01#2026-09-15")?.id).toBe("myevent:k3f9qa2m01");
});
test("a plain event finds itself", () => {
const plain = ownEvent({ id: "myevent:plain00001", repeat: null });
expect(recordFor({ [plain.id]: plain }, "myevent:plain00001")?.id).toBe("myevent:plain00001");
});
test("a feed event belongs to nobody here", () => {
expect(recordFor(store, "genshin:some-event:2026-09-01")).toBeUndefined();
});
test("an occurrence of a rule the reader has since deleted finds nothing", () => {
expect(recordFor({}, "myevent:k3f9qa2m01#2026-09-15")).toBeUndefined();
});
});