lucasw89/gacha-event-tracker
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: sort the first-run game picker alphabetically

Browse Source 
The picker took `available` in feed order — whichever game happened to hold
the first event row — which means something everywhere else in the app and
nothing on this screen, where the reader is scanning for the two or three
names they already know.

Sorted on the name printed on the button rather than the LaneId, since the id
is not what a reader sees, and through localeCompare rather than `<`, because
a code-point sort files hololive Dreams after every capitalised game instead
of between Genshin and Honkai.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This commit is contained in:
Lucas Winther
2026-08-20 05:34:00 +02:00
co-authored by Claude Opus 5
parent 24832844a6
commit 7b6ee62235
3 changed files with 71 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/views.test.tsx
+44
View File
@@ -165,8 +165,52 @@ describe("Welcome (first run)", () => {
// layouts they have not seen yet.
expect(html()).toContain('aria-checked="true"');
});
test("lists the games alphabetically by the name on the button", () => {
// Two games here each pin one half of the sort, and neither is decoration:
//
// `nikke` is Goddess of Victory: Nikke, so its id sorts fifth and its name
// third. That is what makes this a test of sorting by *name* rather than by
// `LaneId` — every other set of ids in this table happens to sort into the
// same order as its names, so a comparator on the id passes them all.
//
// `holodori` is hololive Dreams, the one lowercase name in `games.ts`. A
// code-point sort files it after every capitalised game instead of between
// Goddess and Honkai, which is why the comparator has to be `localeCompare`.
//
// The input order is neither feed order nor id order, so nothing lines up
// by luck.
const markup = render(
<Welcome
available={["zzz", "genshin", "holodori", "hsr", "nikke", "arknights"]}
onConfirm={() => {}}
/>,
);
expect(pickerNames(markup)).toEqual([
"Arknights",
"Genshin Impact",
"Goddess of Victory: Nikke",
"hololive Dreams",
"Honkai: Star Rail",
"Zenless Zone Zero",
]);
});
});
/**
* The game names on the picker buttons, in the order they render.
*
* Pinned to the name span's `flex-1` class: edit that className and this
* returns nothing and the assertion fails loudly, which is the safe direction
* to break in. The text arrives HTML-escaped, so a fixture using a name with an
* apostrophe — Girls' Frontline 2: Exilium — must expect `&#x27;` in it.
*/
function pickerNames(markup: string): string[] {
return [...markup.matchAll(/<span class="flex-1[^"]*"[^>]*>([^<]+)<\/span>/g)].map(
(m) => m[1] ?? "",
);
}
describe("Timeline window", () => {
const DAY = 86_400_000;