Files
rclone/docs/plans/001-protondrive-tier1-workspace/task-19-brief.md
T
2026-11-12 15:12:51 +01:00

1.5 KiB

Task 19: Remove the old libraries

Files:

  • Delete: backend/protondrive/crypto_diff_internal_test.go
  • Keep: backend/protondrive/testdata/oldlib/ and move TestFrozenFixtures and TestFrozenFileFixture into crypto_internal_test.go / download_internal_test.go (they need no old-library import).
  • Modify: go.mod, go.sum

Read "Notes for Tasks 18 to 21" in the handoff before starting: master is no longer the old backend, TestFrozenFileFixture has already moved, and docs/TODO.md has the accurate list of what to keep and delete.

  • Step 1: Record the current binary size: git stash -u is not allowed - instead build master in a worktree: git worktree add ../rclone-master master && (cd ../rclone-master && go build -o /tmp/rclone-old .), note stat -c %s /tmp/rclone-old, then git worktree remove ../rclone-master.
  • Step 2: Move the frozen-fixture tests, delete the differential file, go mod tidy.
  • Step 3: Verify: grep -c 'Proton-API-Bridge\|rclone/go-proton-api\|replace' go.mod prints 0; go build -o /tmp/rclone-new . && stat -c %s /tmp/rclone-new is not larger than the old size; go test -race ./backend/protondrive/... passes; go run bin/cross-compile.go -compile-only (see Makefile target compile_all for the exact flags) succeeds for all targets; RCLONE_CONFIG=/notfound go test ./... has no new failures compared with the list in docs/TODO.md.
  • Step 4: Commit protondrive: drop Proton-API-Bridge and go-proton-api.