Lucas WintherandClaude Opus 5.5
777ae2cc37
Contracts and core: - Feature gains auth and stop; FeatureFactory; core composeServer builds the context, runs the factories, then the job queue from the union of their jobs (R8/R14). startServer uses it; main.ts composes learner, import, studio, AI. - AppConfig/loadConfig own the layout and settings: courseDirs include <dataDir>/courses and <dataDir>/worktrees, studioReposDir, cacheDir, importRoots, uploadMaxMb, aiAllowedBaseUrls, transcribeUrl, python. resolveConfig derives the same for tests; cachePaths shares the importer's cache layout. - canView: the global author role views every course (R14); the learner, studio and AI packages all call it. - migrate(db, packages): core first, then packages in name order. - Media: nosniff on every response, a sandbox CSP on svg/html/js; a Range on an empty file is 416. - courseUrl/lessonUrl and the lesson route patterns live in @stc/contracts. Packages: - import, studio and AI read AppConfig instead of process.env; the importer refuses ids used by studio/repos. - learner migrations run through core migrate; library covers fall back to the importer's cached candidate behind a canView-checked route. - studio preview renders through the learner LessonView (anchors honoured, draft URLs); AI drafts go to the studio draft branch for studio courses (as the requesting user) and to <dataDir>/drafts otherwise, and the generator page says which. Web: tsconfig paths for @stc/<feature>/web browser entries; features.ts imports them by package name; nav.roles hides links by role. Tests: compose, config, canView, media headers, migrations order, covers, preview, nav, SPA bundle without server code, and an end-to-end flow on SQLite and Postgres. Co-Authored-By: Claude Opus 5.5 <[email protected]>
52 lines
2.7 KiB
TypeScript
52 lines
2.7 KiB
TypeScript
import { expect, test } from "bun:test";
|
|
import { mkdtempSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join, resolve } from "node:path";
|
|
import type { AuthUser, Feature, ServerContext } from "@stc/contracts";
|
|
import { composeServer, resolveConfig } from "../src";
|
|
|
|
const FIXTURES = resolve(import.meta.dir, "../../../fixtures/courses");
|
|
const config = () => resolveConfig({ dataDir: mkdtempSync(join(tmpdir(), "stc-compose-")), databaseUrl: "sqlite://:memory:", courseDirs: [FIXTURES] });
|
|
|
|
test("factories get the context; the queue is built from the union of their jobs; auth and stop are honoured", async () => {
|
|
const seen: string[] = [];
|
|
let stopped = 0;
|
|
const user: AuthUser = { id: "u", email: "u@x", name: "U", roles: ["owner"], groups: [] };
|
|
let early: unknown = null;
|
|
const a = (ctx: ServerContext): Feature => {
|
|
// the handle exists while factories run, but enqueuing must wait for the real queue
|
|
try { void ctx.jobs.enqueue("b.work", {}); } catch (e) { early = e; }
|
|
return {
|
|
name: "a",
|
|
routes: { "/api/a": { GET: async (_r, rc) => Response.json({ who: rc.user?.id ?? null, courses: ctx.courses.list().length }) } },
|
|
jobs: { "a.work": async (p) => { seen.push(`a:${JSON.stringify(p)}`); return null; } },
|
|
auth: { userFromRequest: async () => user },
|
|
stop: () => { stopped++; },
|
|
};
|
|
};
|
|
const b = (ctx: ServerContext): Feature => ({
|
|
name: "b",
|
|
routes: { "/api/b": { POST: async () => Response.json({ id: await ctx.jobs.enqueue("a.work", { n: 1 }) }) } },
|
|
jobs: { "b.work": async () => null },
|
|
});
|
|
const s = await composeServer(config(), [a, b]);
|
|
try {
|
|
expect(String(early)).toMatch(/not ready/);
|
|
expect(await (await s.app.fetch(new Request("http://x/api/a"))).json()).toEqual({ who: "u", courses: 1 });
|
|
const { id } = (await (await s.app.fetch(new Request("http://x/api/b", { method: "POST" }))).json()) as { id: string };
|
|
for (let i = 0; i < 200 && (await s.ctx.jobs.get(id))?.status !== "done"; i++) await Bun.sleep(10);
|
|
expect((await s.ctx.jobs.get(id))?.status).toBe("done");
|
|
expect(seen).toEqual(['a:{"n":1}']);
|
|
} finally {
|
|
await s.stop();
|
|
}
|
|
expect(stopped).toBe(1);
|
|
});
|
|
|
|
test("duplicate job kinds and two auth services are refused", async () => {
|
|
const f = (name: string, extra: Partial<Feature>) => (): Feature => ({ name, routes: {}, ...extra });
|
|
await expect(composeServer(config(), [f("x", { jobs: { k: async () => null } }), f("y", { jobs: { k: async () => null } })])).rejects.toThrow(/Duplicate job kind "k"/);
|
|
const auth = { userFromRequest: async () => null };
|
|
await expect(composeServer(config(), [f("x", { auth }), f("y", { auth })])).rejects.toThrow(/AuthService/);
|
|
});
|