It was the board's alone, sitting between two app-wide filters and carrying a line of small print to explain why it was different. It is the same events answering the same question in either view, so it is now one switch: the board plots them, and the checklist keeps its "Not started yet" section. That means the section is off by default, which is a visible change for every existing reader — deliberate, and the same argument the board makes. This app answers what expires next; on fourteen lanes the queued patches are more rows than the thing they came for. `timelineUpcoming` becomes `showUpcoming`, because the old name would now be false, and `adoptRenamed` carries a stored answer across on load. Nothing would be lost by dropping it — `prefs` is one blob under one key, not a key space — but a reader who had switched the future on would find it off with no explanation, and they should not have to say a thing twice. A stored new name always wins, so it cannot overwrite a fresher answer with a stale one. Gating the section alone would have opened a hole: nothing running and everything held back rendered an empty column, because the "nothing to show" line keyed off there being no rows at all rather than none listed. It now counts what is held back and names the switch, as the board does. The split pills stay the board's: the checklist gives these a section with a heading either way, so there is nothing there to mix them into. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
109 lines
4.0 KiB
TypeScript
109 lines
4.0 KiB
TypeScript
import { describe, expect, test } from "bun:test";
|
|
import { adoptNewLanes, adoptRenamed } from "../src/client/state/usePrefs.ts";
|
|
import type { LaneId } from "../src/shared/custom.ts";
|
|
|
|
/**
|
|
* What happens to a reader's games when we add a source.
|
|
*
|
|
* Adding one is our decision, not theirs: a reader who plays two games did not
|
|
* ask for the other twelve, and a calendar that fills up on its own is the
|
|
* thing the first-run picker exists to prevent. So a lane that is new to them
|
|
* arrives switched off — and the one case that must never misfire is the
|
|
* reader who installed before any of this was recorded.
|
|
*/
|
|
|
|
const TRACKED: LaneId[] = ["genshin", "hsr", "zzz"];
|
|
|
|
describe("adoptNewLanes", () => {
|
|
test("an unrecorded reader has everything on their screen recorded, and nothing switched off", () => {
|
|
// Every existing install is in this state. Reading "no record" as "has been
|
|
// offered nothing" would switch off every game they already read.
|
|
expect(adoptNewLanes(TRACKED, undefined, [])).toEqual({
|
|
knownGames: TRACKED,
|
|
});
|
|
});
|
|
|
|
test("a lane they were never offered arrives switched off", () => {
|
|
const patch = adoptNewLanes([...TRACKED, "holodori"], TRACKED, []);
|
|
expect(patch).toEqual({
|
|
knownGames: [...TRACKED, "holodori"],
|
|
hiddenGames: ["holodori"],
|
|
});
|
|
});
|
|
|
|
test("their own game is recorded but never hidden", () => {
|
|
// They asked for it by typing it in. Hiding it would be the app arguing
|
|
// with the reader about a game they just created.
|
|
const patch = adoptNewLanes(
|
|
[...TRACKED, "mygame:limbus-company"],
|
|
TRACKED,
|
|
[],
|
|
);
|
|
expect(patch).toEqual({
|
|
knownGames: [...TRACKED, "mygame:limbus-company"],
|
|
hiddenGames: [],
|
|
});
|
|
});
|
|
|
|
test("nothing new is nothing to write", () => {
|
|
expect(adoptNewLanes(TRACKED, TRACKED, ["zzz"])).toBeNull();
|
|
});
|
|
|
|
test("an empty list is a feed that has not arrived, not a reader with no games", () => {
|
|
// Seeding from it would record nothing and then treat every real game as
|
|
// new the moment the feed lands.
|
|
expect(adoptNewLanes([], undefined, [])).toBeNull();
|
|
expect(adoptNewLanes([], TRACKED, [])).toBeNull();
|
|
});
|
|
|
|
test("a game they had already switched off is not listed twice", () => {
|
|
const patch = adoptNewLanes([...TRACKED, "wuwa"], TRACKED, ["wuwa"]);
|
|
expect(patch?.hiddenGames).toEqual(["wuwa"]);
|
|
});
|
|
|
|
test("their existing choices are left exactly as they were", () => {
|
|
const patch = adoptNewLanes([...TRACKED, "fgo"], TRACKED, ["hsr"]);
|
|
expect(patch?.hiddenGames).toEqual(["hsr", "fgo"]);
|
|
});
|
|
});
|
|
|
|
/**
|
|
* A preference that changed its name.
|
|
*
|
|
* `timelineUpcoming` governed the board alone; `showUpcoming` governs the
|
|
* checklist too. Nothing is lost by dropping the old name — `prefs` is one blob
|
|
* under one key — but a reader who had switched the future on would find it off
|
|
* again with no explanation, which is the same failure as forgetting their view.
|
|
*/
|
|
describe("adoptRenamed", () => {
|
|
test("a reader's old answer is carried across", () => {
|
|
expect(adoptRenamed({ timelineUpcoming: true })).toEqual({
|
|
showUpcoming: true,
|
|
});
|
|
// Both directions: having said no is also an answer.
|
|
expect(adoptRenamed({ timelineUpcoming: false })).toEqual({
|
|
showUpcoming: false,
|
|
});
|
|
});
|
|
|
|
test("the old name never overwrites a fresher one", () => {
|
|
// Once written back under the new name, the leftover must not undo it —
|
|
// otherwise the setting would spring back on every load.
|
|
expect(
|
|
adoptRenamed({ timelineUpcoming: true, showUpcoming: false }),
|
|
).toEqual({ showUpcoming: false });
|
|
});
|
|
|
|
test("it is dropped rather than carried into the stored object", () => {
|
|
// Kept, it would be written straight back and outlive the migration.
|
|
expect(
|
|
Object.keys(adoptRenamed({ timelineUpcoming: true, sort: "doing" })),
|
|
).toEqual(["sort", "showUpcoming"]);
|
|
});
|
|
|
|
test("a reader with neither is left alone", () => {
|
|
expect(adoptRenamed({ sort: "doing" })).toEqual({ sort: "doing" });
|
|
expect(adoptRenamed({})).toEqual({});
|
|
});
|
|
});
|